fix #23038: reduce height of dialogs to 560 pixels #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on windows only ? |
|
Yes |
|
editstyle.ui would still be slightly to large, but only very slightly, so nothing to worry about much (all content should be visible and all buttons should be in reach), the problem with its strange behavoir on resize is solved with PR #756, which got merged. |
|
Do you mind if I step in for stafftype.ui? I'll give a try to the tab approach... |
|
See #763 for a PR dealing with stafftype.ui. |
|
Thanks for stepping in, and of course I don't mind, just the contrary. Actually I hoped that you'd do :-) |
so they easily fit a 1024x600 screen on e.g. a Netbook, without losing anything, at least not on Windows. The dialog editstyle.ui can only get reduced to 573px permanently (it increases to that on the next change otherwise). It'd be nice if we could reduce that dialog by the remain 13px, but isn't strictly needed, with the window title added that dialog might be a few (single digit) pixel higher than 600, but nothing relevant of that dialog should become invisible, so that shouldn't be much of a problem. The only remaining dialog, stafftype.ui, is taken care of in PR musescore#763
|
rebased and adjusted, for it not to conflict with PR #763. |
lasconic
added a commit
that referenced
this pull request
Mar 13, 2014
fix #23038: reduce height of dialogs to 560 pixels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so they easily fit a 1024x600 screen on e.g. a Netbook, without losing
anything