Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #21205: don't show page number on first page #756

Merged
merged 3 commits into from
Mar 12, 2014

Conversation

Jojo-Schmitz
Copy link
Contributor

unless "$P" gets used instead of the default of "$p", just like the default
setting for 1.x scores.
Also add "$c" and "$C" for copyright, with $c being a shortcut for
"$:copyright:" and "$C" showing it on first page only.

unless $P gets used instead of the default of $p, just like the default
setting for 1.x scores.
Also add $c and $C for copyright, with $c being a shortcut for
$:copyright: and $C showing it on first page only.
generated in cpp rather than in the ui files.
@Jojo-Schmitz
Copy link
Contributor Author

That last commit should make translation much easier, as only the non-html part is marked for translation and all the formatting stuff remains constant.
As a label in the ui file it was also causing trouble when resizing that dialog. As a tooltip in the ui it would still be pretty difficult to translate and format properly due to HTML/RichText format, and would probably be needed twice, for the showHeader and the showFooter.
So moving it into cpp seems to catch several birds with one stone.
Downside: that stone (the code) isn't really pretty...
And the tooltip disappears when typing into the edit fields.

wschweer added a commit that referenced this pull request Mar 12, 2014
fix #21205: don't show page number on first page
@wschweer wschweer merged commit fe8e675 into musescore:master Mar 12, 2014
@Jojo-Schmitz Jojo-Schmitz deleted the 21207-text-macros branch March 12, 2014 08:18
@Jojo-Schmitz
Copy link
Contributor Author

Strange, the translation of that 'handmade' tooltip doesn't seem to work, any idea why?
Is it because it is a static QString?

@lasconic
Copy link
Contributor

Yes. That does't work. Constructing the string as a static string is the problem. Translate_noop will mark the string has being translatable but then you need to call translate() with this string. If the string has been concatenated before calling translate, it will not work ... so concatenation needs to happen non statically or we keep HTML... which was not a problem for translators in 1.3...

@Jojo-Schmitz
Copy link
Contributor Author

having it non-static inside EditStyle::EditStyle() and there using tr() instead of QT_TRANSLATE_NOOP() should fix the problem then? Opens up the nice ability to construct the list of meta tags online and for the current score, have a PR for that almost ready.

That part of the dialog didn't exist in 1.3 -> no problem for translators :-)

@lasconic
Copy link
Contributor

There were other HTML part, like in the about box.

@Jojo-Schmitz
Copy link
Contributor Author

Right. They are still difficult, but not as format dependant as that tooltip

@Jojo-Schmitz
Copy link
Contributor Author

see PR #765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants