-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #21205: don't show page number on first page #756
Conversation
unless $P gets used instead of the default of $p, just like the default setting for 1.x scores. Also add $c and $C for copyright, with $c being a shortcut for $:copyright: and $C showing it on first page only.
generated in cpp rather than in the ui files.
That last commit should make translation much easier, as only the non-html part is marked for translation and all the formatting stuff remains constant. |
fix #21205: don't show page number on first page
Strange, the translation of that 'handmade' tooltip doesn't seem to work, any idea why? |
Yes. That does't work. Constructing the string as a static string is the problem. Translate_noop will mark the string has being translatable but then you need to call translate() with this string. If the string has been concatenated before calling translate, it will not work ... so concatenation needs to happen non statically or we keep HTML... which was not a problem for translators in 1.3... |
having it non-static inside EditStyle::EditStyle() and there using tr() instead of QT_TRANSLATE_NOOP() should fix the problem then? Opens up the nice ability to construct the list of meta tags online and for the current score, have a PR for that almost ready. That part of the dialog didn't exist in 1.3 -> no problem for translators :-) |
There were other HTML part, like in the about box. |
Right. They are still difficult, but not as format dependant as that tooltip |
see PR #765 |
unless "$P" gets used instead of the default of "$p", just like the default
setting for 1.x scores.
Also add "$c" and "$C" for copyright, with $c being a shortcut for
"$:copyright:" and "$C" showing it on first page only.