Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3] Fix #319584: Many percussions elements/sounds are not getting translated in status bar and Edit Drumset dialog #7891

Closed
wants to merge 1 commit into from
Closed

[MU3] Fix #319584: Many percussions elements/sounds are not getting translated in status bar and Edit Drumset dialog #7891

wants to merge 1 commit into from

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Apr 4, 2021 •
edited
Loading

Resolves: https://musescore.org/en/node/319584

We'd need to mix and match

MuseScore/src/libmscore/drumset.cpp

Lines 256 to 312 in 6fe71f9

smDrumset->drum(35) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Acoustic Bass Drum"), NoteHead::Group::HEAD_NORMAL, 7, Direction::DOWN, 1);
smDrumset->drum(36) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Bass Drum 1"), NoteHead::Group::HEAD_NORMAL, 7, Direction::DOWN, 1,
Qt::Key_B);
smDrumset->drum(37) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Side Stick"), NoteHead::Group::HEAD_CROSS, 3, Direction::UP);
smDrumset->drum(38) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Acoustic Snare"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP, 0,
Qt::Key_A);
smDrumset->drum(40) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Electric Snare"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
smDrumset->drum(41) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Low Floor Tom"), NoteHead::Group::HEAD_NORMAL, 5, Direction::UP);
smDrumset->drum(42) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Closed Hi-Hat"), NoteHead::Group::HEAD_CROSS, -1, Direction::UP, 0,
Qt::Key_G);
smDrumset->drum(43) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"High Floor Tom"), NoteHead::Group::HEAD_NORMAL, 5, Direction::DOWN, 1);
smDrumset->drum(44) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Pedal Hi-Hat"), NoteHead::Group::HEAD_CROSS, 9, Direction::DOWN, 1,
Qt::Key_F);
smDrumset->drum(45) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Low Tom"), NoteHead::Group::HEAD_NORMAL, 2, Direction::UP);
smDrumset->drum(46) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Open Hi-Hat"), NoteHead::Group::HEAD_CROSS, 1, Direction::UP);
smDrumset->drum(47) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Low-Mid Tom"), NoteHead::Group::HEAD_NORMAL, 1, Direction::UP);
smDrumset->drum(48) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Hi-Mid Tom"), NoteHead::Group::HEAD_NORMAL, 0, Direction::UP);
smDrumset->drum(49) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Crash Cymbal 1"), NoteHead::Group::HEAD_CROSS, -2, Direction::UP, 0,
Qt::Key_C);
smDrumset->drum(50) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"High Tom"), NoteHead::Group::HEAD_NORMAL, 0, Direction::UP, 0,
Qt::Key_E);
smDrumset->drum(51) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Ride Cymbal 1"), NoteHead::Group::HEAD_CROSS, 0, Direction::UP, 0,
Qt::Key_D);
smDrumset->drum(52) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Chinese Cymbal"), NoteHead::Group::HEAD_CROSS, -3, Direction::UP);
smDrumset->drum(53) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Ride Bell"), NoteHead::Group::HEAD_DIAMOND, 0, Direction::UP);
smDrumset->drum(54) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Tambourine"), NoteHead::Group::HEAD_DIAMOND, 2, Direction::UP);
smDrumset->drum(55) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Splash Cymbal"), NoteHead::Group::HEAD_CROSS, -3, Direction::UP);
smDrumset->drum(56) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Cowbell"), NoteHead::Group::HEAD_TRIANGLE_DOWN, 1, Direction::UP);
smDrumset->drum(57) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Crash Cymbal 2"), NoteHead::Group::HEAD_CROSS, -3, Direction::UP);
smDrumset->drum(59) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Ride Cymbal 2"), NoteHead::Group::HEAD_CROSS, 2, Direction::UP);
smDrumset->drum(63) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Open Hi Conga"), NoteHead::Group::HEAD_CROSS, 4, Direction::UP);
smDrumset->drum(64) = DrumInstrument(QT_TRANSLATE_NOOP("drumset",
"Low Conga"), NoteHead::Group::HEAD_CROSS, 6, Direction::UP);
and the more complete

MuseScore/src/importexport/guitarpro/internal/importgtp.cpp

Lines 303 to 373 in 6fe71f9

// new drumset determined via guitar pro (third argument specifies position on staff, 10 = C3, 9 = D3, 8 = E3,...)
gpDrumset->drum(27) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "High Q"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(28) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Slap"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(29) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Scratch Push"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(30) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Scratch Pull"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(31) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Sticks"), NoteHead::Group::HEAD_CROSS, 3, Direction::UP);
gpDrumset->drum(32) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Square Click"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(33) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Metronome Click"), NoteHead::Group::HEAD_CROSS, 3, Direction::UP);
gpDrumset->drum(34) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Metronome Bell"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(35)
= DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Acoustic Bass Drum"), NoteHead::Group::HEAD_NORMAL, 7, Direction::UP);
gpDrumset->drum(36) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Bass Drum 1"), NoteHead::Group::HEAD_NORMAL, 7, Direction::UP);
gpDrumset->drum(37) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Side Stick"), NoteHead::Group::HEAD_CROSS, 3, Direction::UP);
gpDrumset->drum(38) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Acoustic Snare"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(39) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Hand Clap"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(40) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Electric Snare"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(41) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Low Floor Tom"), NoteHead::Group::HEAD_NORMAL, 6, Direction::UP);
gpDrumset->drum(42) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Closed Hi-Hat"), NoteHead::Group::HEAD_CROSS, -1, Direction::UP);
gpDrumset->drum(43) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "High Floor Tom"), NoteHead::Group::HEAD_NORMAL, 6, Direction::UP);
gpDrumset->drum(44) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Pedal Hi-Hat"), NoteHead::Group::HEAD_CROSS, 9, Direction::UP);
gpDrumset->drum(45) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Low Tom"), NoteHead::Group::HEAD_NORMAL, 5, Direction::UP);
gpDrumset->drum(46) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Open Hi-Hat"), NoteHead::Group::HEAD_XCIRCLE, -1, Direction::UP);
gpDrumset->drum(47) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Low-Mid Tom"), NoteHead::Group::HEAD_NORMAL, 4, Direction::UP);
gpDrumset->drum(48) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Hi-Mid Tom"), NoteHead::Group::HEAD_NORMAL, 2, Direction::UP);
gpDrumset->drum(49) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Crash Cymbal 1"), NoteHead::Group::HEAD_CROSS, -1, Direction::UP);
gpDrumset->drum(50) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "High Tom"), NoteHead::Group::HEAD_NORMAL, 1, Direction::UP);
gpDrumset->drum(51) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Ride Cymbal 1"), NoteHead::Group::HEAD_CROSS, 0, Direction::UP);
gpDrumset->drum(52) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Chinese Cymbal"), NoteHead::Group::HEAD_CROSS, -3, Direction::UP);
gpDrumset->drum(53) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Ride Bell"), NoteHead::Group::HEAD_DIAMOND, 0, Direction::UP);
gpDrumset->drum(54) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Tambourine"), NoteHead::Group::HEAD_CROSS, 2, Direction::UP);
gpDrumset->drum(55) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Splash Cymbal"), NoteHead::Group::HEAD_CROSS, -2, Direction::UP);
gpDrumset->drum(56) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Cowbell Medium"), NoteHead::Group::HEAD_NORMAL, 0, Direction::UP);
gpDrumset->drum(57) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Crash Cymbal 2"), NoteHead::Group::HEAD_CROSS, -2, Direction::UP);
gpDrumset->drum(58) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Vibraslap"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(59) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Ride Cymbal 2"), NoteHead::Group::HEAD_DIAMOND, 0, Direction::UP);
gpDrumset->drum(60) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Hi Bongo"), NoteHead::Group::HEAD_NORMAL, 8, Direction::UP);
gpDrumset->drum(61) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Low Bongo"), NoteHead::Group::HEAD_NORMAL, 9, Direction::UP);
gpDrumset->drum(62) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Mute Hi Conga"), NoteHead::Group::HEAD_CROSS, 5, Direction::UP);
gpDrumset->drum(63) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Open Hi Conga"), NoteHead::Group::HEAD_CROSS, 4, Direction::UP);
gpDrumset->drum(64) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Low Conga"), NoteHead::Group::HEAD_CROSS, 6, Direction::UP);
gpDrumset->drum(65) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "High Timbale"), NoteHead::Group::HEAD_CROSS, 8, Direction::UP);
gpDrumset->drum(66) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Low Timbale"), NoteHead::Group::HEAD_CROSS, 9, Direction::UP);
gpDrumset->drum(67) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "High Agogo"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(68) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Low Agogo"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(69) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Cabasa"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(70) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Maracas"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(71) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Short Whistle"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(72) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Long Whistle"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(73) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Short Güiro"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(74) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Long Güiro"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(75) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Claves"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(76) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Hi Wood Block"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(77) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Low Wood Block"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(78) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Mute Cuica"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(79) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Open Cuica"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(80) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Mute Triangle"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(81) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Open Triangle"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(82) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Shaker"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(83) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Sleigh Bell"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(84) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Bell Tree"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(85) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Castanets"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(86) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Mute Surdo"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(87) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Open Surdo"), NoteHead::Group::HEAD_NORMAL, 3, Direction::UP);
gpDrumset->drum(91) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Snare (Rim shot)"), NoteHead::Group::HEAD_DIAMOND, 3, Direction::UP);
gpDrumset->drum(93) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Ride (Edge)"), NoteHead::Group::HEAD_CROSS, 0, Direction::UP);
//Additional clutch presets (midi by default can't play this)
gpDrumset->drum(99) = DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Cowbell Low"), NoteHead::Group::HEAD_TRIANGLE_UP, 1, Direction::UP);
gpDrumset->drum(102)
= DrumInstrument(QT_TRANSLATE_NOOP("drumset", "Cowbell High"), NoteHead::Group::HEAD_TRIANGLE_UP, -1, Direction::UP);

with instruments.xml

  • Fix missing translations for Hi Congas
  • Fix missing translation for Hi Bongo
  • Fix missing translation for Hi Woodblock
  • Fix missing translation for Vibraslap
  • Fix wrong translation/name for Sleigh Bell
  • Fix missing translations for Snare drums
  • Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though
  • Fix missing translations for Toms
  • Fix missing/wrong translation/name and sound for Slap
  • Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
  • Fix missing translations for Bass Drums
  • Fix missing translations for Ride Cymbal

To do: Look after the marching percussion stuff, it seems to be using an entirely different number-to-name mapping? Here we may need to add strings (and subsequently translate them), and by other means than done in ths PR so far. I'd rather not though this here and now...

For master see #7893

@Jojo-Schmitz Jojo-Schmitz force-pushed the instruments-translations branch 3 times, most recently from 0a19d85 to f3d5646 Compare April 4, 2021 11:49
This was referenced Apr 4, 2021
Merged
Closed
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 10, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
2b1ba4d 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
dda938a 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 17, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
e991441 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 26, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
d9de7f4 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 26, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
ff02d6a 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
@vpereverzev
Copy link
Member

merged in master, 3.x merges are closed

@Jojo-Schmitz Jojo-Schmitz deleted the instruments-translations branch April 28, 2021 11:53
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 11, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
05c9298 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
912aabb 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 1, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
a8ed4aa 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
7769306 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
29ae337 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
3615a1b 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
6308bb5 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
e7cd3d2 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
0e9a52f 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
e9439fc 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 18, 2021
@shoogle @Jojo-Schmitz
instruments.xml: Make drum names refer to instrument not sound
db392c2 
Backport of musescore#8835
But see also musescore#7892, resp. musescore#7891
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
2e9530e 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@shoogle @Jojo-Schmitz
instruments.xml: Make drum names refer to instrument not sound
a7195bf 
Backport of musescore#8835
But see also musescore#7892, resp. musescore#7891
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
a63a3b1 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@shoogle @Jojo-Schmitz
instruments.xml: Make drum names refer to instrument not sound
2cbb4cc 
Backport of musescore#8835
But see also musescore#7892, resp. musescore#7891
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
@shoogle @Jojo-Schmitz
instruments.xml: Make drum names refer to instrument not sound
8e1dc17 
Backport of musescore#8835
But see also musescore#7892, resp. musescore#7891
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 1, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
@shoogle @Jojo-Schmitz
instruments.xml: Make drum names refer to instrument not sound
3c2f2c6 
Backport of musescore#8835
But see also musescore#7892, resp. musescore#7891
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@shoogle @Jojo-Schmitz
instruments.xml: Make drum names refer to instrument not sound
5624671 
Backport of musescore#8835
But see also musescore#7892, resp. musescore#7891
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
e4290b8 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@shoogle @Jojo-Schmitz
instruments.xml: Make drum names refer to instrument not sound
cfb3821 
Backport of musescore#8835
But see also musescore#7892, resp. musescore#7891
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 9, 2021
@shoogle @Jojo-Schmitz
instruments.xml: Make drum names refer to instrument not sound
4e29282 
Backport of musescore#8835
But see also musescore#7892, resp. musescore#7891
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
e94304d 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@shoogle @Jojo-Schmitz
instruments.xml: Make drum names refer to instrument not sound
1e2b0ce 
Backport of musescore#8835
But see also musescore#7892, resp. musescore#7891
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
5021ac5 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@shoogle @Jojo-Schmitz
instruments.xml: Make drum names refer to instrument not sound
27d8c33 
Backport of musescore#8835
But see also musescore#7892, resp. musescore#7891
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 26, 2021
@shoogle @Jojo-Schmitz
instruments.xml: Make drum names refer to instrument not sound
230124f 
Backport of musescore#8835
But see also musescore#7892, resp. musescore#7891
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 29, 2021
@shoogle @Jojo-Schmitz
instruments.xml: Make drum names refer to instrument not sound
ac7c5b1 
Backport of musescore#8835
But see also musescore#7892, resp. musescore#7891
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
@shoogle @Jojo-Schmitz
instruments.xml: Make drum names refer to instrument not sound
83f0f06 
Backport of musescore#8835
But see also musescore#7892, resp. musescore#7891
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@Jojo-Schmitz
Fix #319584: Many percussions elements/sounds are not getting transla…
ae806c8 
…ted in status bar and Edit Drumset dialog

* Fix missing translations for Hi Congas
* Fix missing translation for Hi Bongo
* Fix missing translation for Hi Woodblock
* Fix missing translation for Vibraslap
* Fix wrong translation/name for Sleigh Bell
* Fix missing translations for Snare drums
* Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though.
* Fix missing translations for Toms
* Fix missing/wrong translation/name and sound for Slap
* Fix/add wrong translation/missing name and sound for Castanets/Hand Clap
* Fix missing translations for Bass Drums
* Fix missing translations for Ride Cymbal

Backport of musescore#7892, resp. duplicate of musescore#7891
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@shoogle @Jojo-Schmitz
instruments.xml: Make drum names refer to instrument not sound
9bf9b05 
Backport of musescore#8835
But see also musescore#7892, resp. musescore#7891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jojo-Schmitz @vpereverzev