[MU4] Fix animations in notehead chooser #7892

aaaeka · 2021-04-04T11:55:04Z

Resolves: #7770

Unless I don't understand something, I found signals layoutAboutToBeChanged() and layoutChanged() to be unnecessary. Removing them also fixes the animation.

I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
I created the test (mtest, vtest, script test) to verify the changes I made

vshalkevich · 2021-04-06T10:18:10Z

PR seems good

…ted in status bar and Edit Drumset dialog * Fix missing translations for Hi Congas * Fix missing translation for Hi Bongo * Fix missing translation for Hi Woodblock * Fix missing translation for Vibraslap * Fix wrong translation/name for Sleigh Bell * Fix missing translations for Snare drums * Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though. * Fix missing translations for Toms * Fix missing/wrong translation/name and sound for Slap * Fix/add wrong translation/missing name and sound for Castanets/Hand Clap * Fix missing translations for Bass Drums * Fix missing translations for Ride Cymbal Backport of musescore#7892, resp. duplicate of musescore#7891

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

…ted in status bar and Edit Drumset dialog * Fix missing translations for Hi Congas * Fix missing translation for Hi Bongo * Fix missing translation for Hi Woodblock * Fix missing translation for Vibraslap * Fix wrong translation/name for Sleigh Bell * Fix missing translations for Snare drums * Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though. * Fix missing translations for Toms * Fix missing/wrong translation/name and sound for Slap * Fix/add wrong translation/missing name and sound for Castanets/Hand Clap * Fix missing translations for Bass Drums * Fix missing translations for Ride Cymbal Backport of musescore#7892, resp. duplicate of musescore#7891

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

…ted in status bar and Edit Drumset dialog * Fix missing translations for Hi Congas * Fix missing translation for Hi Bongo * Fix missing translation for Hi Woodblock * Fix missing translation for Vibraslap * Fix wrong translation/name for Sleigh Bell * Fix missing translations for Snare drums * Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though. * Fix missing translations for Toms * Fix missing/wrong translation/name and sound for Slap * Fix/add wrong translation/missing name and sound for Castanets/Hand Clap * Fix missing translations for Bass Drums * Fix missing translations for Ride Cymbal Backport of musescore#7892, resp. duplicate of musescore#7891

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

…ted in status bar and Edit Drumset dialog * Fix missing translations for Hi Congas * Fix missing translation for Hi Bongo * Fix missing translation for Hi Woodblock * Fix missing translation for Vibraslap * Fix wrong translation/name for Sleigh Bell * Fix missing translations for Snare drums * Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though. * Fix missing translations for Toms * Fix missing/wrong translation/name and sound for Slap * Fix/add wrong translation/missing name and sound for Castanets/Hand Clap * Fix missing translations for Bass Drums * Fix missing translations for Ride Cymbal Backport of musescore#7892, resp. duplicate of musescore#7891

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

…ted in status bar and Edit Drumset dialog * Fix missing translations for Hi Congas * Fix missing translation for Hi Bongo * Fix missing translation for Hi Woodblock * Fix missing translation for Vibraslap * Fix wrong translation/name for Sleigh Bell * Fix missing translations for Snare drums * Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though. * Fix missing translations for Toms * Fix missing/wrong translation/name and sound for Slap * Fix/add wrong translation/missing name and sound for Castanets/Hand Clap * Fix missing translations for Bass Drums * Fix missing translations for Ride Cymbal Backport of musescore#7892, resp. duplicate of musescore#7891

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

…ted in status bar and Edit Drumset dialog * Fix missing translations for Hi Congas * Fix missing translation for Hi Bongo * Fix missing translation for Hi Woodblock * Fix missing translation for Vibraslap * Fix wrong translation/name for Sleigh Bell * Fix missing translations for Snare drums * Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though. * Fix missing translations for Toms * Fix missing/wrong translation/name and sound for Slap * Fix/add wrong translation/missing name and sound for Castanets/Hand Clap * Fix missing translations for Bass Drums * Fix missing translations for Ride Cymbal Backport of musescore#7892, resp. duplicate of musescore#7891

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

…ted in status bar and Edit Drumset dialog * Fix missing translations for Hi Congas * Fix missing translation for Hi Bongo * Fix missing translation for Hi Woodblock * Fix missing translation for Vibraslap * Fix wrong translation/name for Sleigh Bell * Fix missing translations for Snare drums * Fix missing translations for Bell Tree by changing it to the apparently more correct "Mark Tree", requires updated translations though. * Fix missing translations for Toms * Fix missing/wrong translation/name and sound for Slap * Fix/add wrong translation/missing name and sound for Castanets/Hand Clap * Fix missing translations for Bass Drums * Fix missing translations for Ride Cymbal Backport of musescore#7892, resp. duplicate of musescore#7891

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

Fix animation in notehead chooser

663f49c

aaaeka changed the title ~~Fix animations in notehead chooser~~ [MU4] Fix animations in notehead chooser Apr 4, 2021

Jojo-Schmitz mentioned this pull request Apr 6, 2021

[MU3 Issue] MuseScore 3.6.3 or 3.7.0, PRs to be merged and issues to be fixed. #7449

Closed

vpereverzev merged commit 7aaf230 into musescore:master Apr 19, 2021

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 18, 2021

instruments.xml: Make drum names refer to instrument not sound

db392c2

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021

instruments.xml: Make drum names refer to instrument not sound

a7195bf

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021

instruments.xml: Make drum names refer to instrument not sound

2cbb4cc

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021

instruments.xml: Make drum names refer to instrument not sound

8e1dc17

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021

instruments.xml: Make drum names refer to instrument not sound

3c2f2c6

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021

instruments.xml: Make drum names refer to instrument not sound

5624671

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021

instruments.xml: Make drum names refer to instrument not sound

cfb3821

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 9, 2021

instruments.xml: Make drum names refer to instrument not sound

4e29282

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021

instruments.xml: Make drum names refer to instrument not sound

1e2b0ce

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021

instruments.xml: Make drum names refer to instrument not sound

27d8c33

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 26, 2021

instruments.xml: Make drum names refer to instrument not sound

230124f

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 29, 2021

instruments.xml: Make drum names refer to instrument not sound

ac7c5b1

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022

instruments.xml: Make drum names refer to instrument not sound

83f0f06

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023

instruments.xml: Make drum names refer to instrument not sound

9bf9b05

Backport of musescore#8835 But see also musescore#7892, resp. musescore#7891

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MU4] Fix animations in notehead chooser #7892

[MU4] Fix animations in notehead chooser #7892

aaaeka commented Apr 4, 2021

vshalkevich commented Apr 6, 2021

[MU4] Fix animations in notehead chooser #7892

[MU4] Fix animations in notehead chooser #7892

Conversation

aaaeka commented Apr 4, 2021

vshalkevich commented Apr 6, 2021