Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3 Backend] ENG-25: Improve placement defaults #8325

Merged
merged 1 commit into from Jul 6, 2021
Merged

[MU3 Backend] ENG-25: Improve placement defaults #8325

merged 1 commit into from Jul 6, 2021

Conversation

iveshenry18
Copy link
Contributor

Resolves: ENG-25: Dynamics should appear above vocal staves

This adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

This PR is built on commits from #8298.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@Jojo-Schmitz
Copy link
Contributor

rebase needed

@iveshenry18
Copy link
Contributor Author

Rebased!

@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Jun 29, 2021
Closed
@iveshenry18
ENG-25: Bolster placement defaults
7a02054 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.
@vpereverzev vpereverzev merged commit 0484329 into musescore:3.6.2_backend Jul 6, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 6, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
bdf9f8b 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 6, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
0dfda93 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325
@iveshenry18 iveshenry18 mentioned this pull request Jul 7, 2021
Merged
8 tasks
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
8ef4c87 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
b42a3f0 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
1b6dcf7 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
38e841d 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
aeb4e72 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
833b6a8 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
ad40f99 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
cf4c92d 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
2acfe80 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
099ca70 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
36e1437 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
5764ae6 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
89a59ca 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
b0360fb 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 1, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
1d18aad 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
b704c57 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
6819c58 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
cecf830 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@iveshenry18 @Jojo-Schmitz
ENG-25: Bolster placement defaults
aa38265 
This commit adds some context-aware placement defaults for text and
dynamics (in the case that neither "placement" nor "default-y" nor
"relative-y" are specified). Namely, both expression text and dynamics
are placed below the staff unless it is a vocal staff.

To this end, there are some simple checks added to discern whether a
part is a vocal part, which is currently a simple check against the
name of the staff and a check for the presence of lyrics. Additionally,
the "expression text" is currently defined by the presence of italics in
the _wordsText, and an absence of _tempoText.

Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jojo-Schmitz Jojo-Schmitz Jojo-Schmitz left review comments

@oktophonie oktophonie oktophonie approved these changes

@vpereverzev vpereverzev vpereverzev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iveshenry18 @Jojo-Schmitz @oktophonie @vpereverzev