[MU3 Backend] MusicXML compiler warnings #8554

iveshenry18 · 2021-07-06T16:48:33Z

Resolves: Compiler warnings mentioned in #8492, #8325, and #8284

I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
I created the test (mtest, vtest, script test) to verify the changes I made

Previously, only the first beam was taken into account when importing Beam::Mode. This commit adds a mechanism to collect the beam type for all beams and make a more correct choice about Beam::Mode (including BEGIN32 and BEGIN64). Additionally, it adds handling of these modes to the export code. Now the round trip from .mscx -> .xml -> .mscx is correct and complete *when beam modes are specified explicitly in the .mscx*; however, more thorough handling of Beam::Mode::AUTO (where it results in the equivalent of BEGIN32 or BEGIN64) on export needs to be done. Duplicate of musescore#8492, plus fixing 4 compiler warnings, see musescore#8554

This commit adds some context-aware placement defaults for text and dynamics (in the case that neither "placement" nor "default-y" nor "relative-y" are specified). Namely, both expression text and dynamics are placed below the staff unless it is a vocal staff. To this end, there are some simple checks added to discern whether a part is a vocal part, which is currently a simple check against the name of the staff and a check for the presence of lyrics. Additionally, the "expression text" is currently defined by the presence of italics in the _wordsText, and an absence of _tempoText. Duplicate of musescore#8325, plus fixing a compiler warning, see musescore#8554

importexport/musicxml/importmxmlpass2.cpp

Jojo-Schmitz · 2021-07-18T08:28:02Z

importexport/musicxml/importmxmlpass2.cpp

@@ -4926,7 +4926,7 @@ Note* MusicXMLParserPass2::note(const QString& partId,
            else if (_e.name() == "stem")
                  stem(stemDir, noStem);
            else if (_e.name() == "type") {
-                  small = _e.attributes().value("size") == "cue" | _e.attributes().value("size") == "grace-cue";
+                  small = (_e.attributes().value("size") == "cue") || (_e.attributes().value("size") == "grace-cue");


Hmm, I was suggesting the parenthezise the entire || expression, not their elements

Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554