Fix #22917 - Previous fix actually disable precise bar line editing #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne grips. When editing is exited, an (extra?) final call to BarLine::endEditDrag() is made **after** the last drag: it was finding shiftDrag turned off by the last call and forced the bar line extrema to coarse precision. See http://musescore.org/en/node/22917#comment-99269 Fixes: - resetting shiftDrag moved from endEditDrag() to endEdit(); - added a test at the beginning of endEditDrag() skipping it, if there is no drag. Also fixed: - a test for shiftDrag swapped with !shiftDrag - an assumption that staves always have 5 lines.
|
Thank you for looking into this. |
lasconic
added a commit
that referenced
this pull request
Apr 15, 2014
…s_fix Fix #22917 - Previous fix actually disable precise bar line editing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #22917 - Previous fix actually disable high-precision bar line editing.
When editing is exited, an (extra?) final call to BarLine::endEditDrag() is made after the last drag: it was finding shiftDrag turned off by the last call and forced the bar line extrema to coarse precision.
See http://musescore.org/en/node/22917#comment-99269
Fixes:
Also fixed: