Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #22917 - Previous fix actually disable precise bar line editing #836

Merged
merged 1 commit into from
Apr 15, 2014
Merged

Fix #22917 - Previous fix actually disable precise bar line editing #836

merged 1 commit into from
Apr 15, 2014

Commits on Apr 14, 2014

  1. Fix #22917 - Previous fix actually disable precise dragging of bar li…

    …ne grips.
    
    When editing is exited, an (extra?) final call to BarLine::endEditDrag() is made **after** the last drag: it was finding shiftDrag turned off by the last call and forced the bar line extrema to coarse precision.
    See http://musescore.org/en/node/22917#comment-99269
    
    Fixes:
    - resetting shiftDrag moved from endEditDrag() to endEdit();
    - added a test at the beginning of endEditDrag() skipping it, if there is no drag.
    
    Also fixed:
    - a test for shiftDrag swapped with !shiftDrag
    - an assumption that staves always have 5 lines.
    mgavioli committed Apr 14, 2014
    Configuration menu
    Copy the full SHA
    f23a9f0 View commit details
    Browse the repository at this point in the history