Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3 Backend] MusicXML compiler warnings #8554

Merged
merged 4 commits into from
Aug 9, 2021
Merged

[MU3 Backend] MusicXML compiler warnings #8554

merged 4 commits into from
Aug 9, 2021

Commits on Jul 27, 2021

  1. Add missing parentheses in writeBeam conditional

    @iveshenry18
    iveshenry18 committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    638776e View commit details
    Browse the repository at this point in the history

  2. Add brackets to ambiguous else in MusicXML import

    @iveshenry18
    iveshenry18 committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    14116d3 View commit details
    Browse the repository at this point in the history

  3. Fix incorrect OR operator in xml import

    @iveshenry18
    iveshenry18 committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    ad26549 View commit details
    Browse the repository at this point in the history

  4. Fix Qt < 5.10 compatibility in MusicXML import 

    Qt 5.9 and earlier does not support QString::back(). This commit adds a
check for this and an alternative.
    @iveshenry18
    iveshenry18 committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    fddd146 View commit details
    Browse the repository at this point in the history