Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SMuFL anchors #8958

Merged
merged 2 commits into from Aug 31, 2021
Merged

Conversation

cbjeukendrup
Copy link
Contributor

@cbjeukendrup cbjeukendrup commented Aug 29, 2021

Resolves:

While working on #8952, I wrote some extra drawing code for debugging bboxes, positioning, anchors etc.. This revealed that the SMuFL anchors were hardly ever in the correct place, so stems were not attached correctly to noteheads. They always seemed to be at 80% of their correct position from the origin. And exactly that was the case. Now it looks like this:
Schermafbeelding 2021-08-29 om 18 02 08
(red + means origin of element; orange + is flag anchor point; yellow + is notehead anchor point; the green rect is the bounding box. Please don't mind the badly-placed and purple-coloured stems in this picture.)

Here is it without those extra things:
Schermafbeelding 2021-08-29 om 18 38 26

It also turned out that the metadata file for Petaluma was not added to the application, so for Petaluma the anchors did not work at all. That's fixed too with this PR.

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381

Backport of musescore#8958 (not a very straight one...)
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Aug 30, 2021

What puzzles me is that there are no vtest differences reported? There should be some minor ones (but for the better)

@cbjeukendrup
Copy link
Contributor Author

What puzzles me is that there are no vtest differences reported? There should be some minor ones (but for the better)

That makes me a little worried too, also because I remember a PR of yours for which we also expected vtest differences but there wasn't. Makes me wonder whether the vtests are working at all...

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Aug 30, 2021

Yes, #8853. Something about the vtests seems severly broken

@cbjeukendrup
Copy link
Contributor Author

It probably starts going wrong because the vtest input files are still old mscx files. It is unclear to me whether any output images are generated at all.

Then the compare step silently fails:

Run ./vtest/vtest.sh -c compare
MuseScore VTest
RUN_CMD: compare
SCORES_DIR: ./vtest/scores
ARTIFACTS_DIR: vtest.artifacts
MSCORE_BIN: build.debug/install/bin/mscore
DPI: 130
Compare PNG files and references
ls: cannot access 'vtest.artifacts/ref/*.ref.png': No such file or directory

Will try to fix it tomorrow.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Aug 31, 2021

It is a separate issue though, not the business of this PR here. Which is good as it is, and should get merged sooner rather than later ;-)
See #8977.

BTW: thanks for splitting off the unrelated changes into a separate commit, helps understanding what this is about.

@oktophonie oktophonie added this to In progress in [MU4.0 - ENGRAVING] via automation Aug 31, 2021
[MU4.0 - ENGRAVING] automation moved this from In progress to Reviewer approved Aug 31, 2021
@vpereverzev vpereverzev merged commit b7642bb into musescore:master Aug 31, 2021
[MU4.0 - ENGRAVING] automation moved this from Reviewer approved to Done Aug 31, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 31, 2021
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381

Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't
apply here at all)
@cbjeukendrup cbjeukendrup deleted the fix_smufl_anchors branch August 31, 2021 18:00
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381

Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't
apply here at all)
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381

Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't
apply here at all)
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381

Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't
apply here at all)
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 9, 2021
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381

Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't
apply here at all)
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381

Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't
apply here at all)
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381

Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't
apply here at all)
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 26, 2021
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381

Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't
apply here at all)
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 29, 2021
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381

Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't
apply here at all)
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381

Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't
apply here at all)
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381

Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't
apply here at all)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants