Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] [Engraving] Note stems don't take the SMuFL anchors "stemUpNW" and "stemDownSW" into account #8952

Closed
cbjeukendrup opened this issue Aug 27, 2021 · 8 comments · Fixed by #9237
Assignees

Comments

@cbjeukendrup
Copy link
Contributor

cbjeukendrup commented Aug 27, 2021

Describe the bug
The stems of notes and chords don't take the stemUpNW and stemDownSW SMuFL anchors of the flag into account. This causes that the stem has an incorrect length.
For normal flags, this is not very visible (but if you look closely, you might see an edge at some zoom levels when anti-aliasing is turned on). The problem becomes very obvious with straight flags*:

Straight flags wrong stem length

* Not yet possible, but I will implement this as soon as this issue is fixed and PR #8867 gets merged.

Additional context
For the Shadow Note, it already works correctly because I implemented this in PR #7316.

@cbjeukendrup
Copy link
Contributor Author

I would like to fix this issue.

@oktophonie oktophonie added this to To do in [MU4.0 - ENGRAVING] via automation Aug 28, 2021
@oktophonie
Copy link
Contributor

Be my guest ;)

If you're in that bit of the code, is it worth investigating a fix for stemUpSE and stemDownNW on certain noteheads like the cross and triangle? They seem almost right, but not quite:
x-noteheads

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Aug 28, 2021

That 'edge' on normal flags:
image

@DmitryArefiev
Copy link
Contributor

Hi @cbjeukendrup , can you help with creating straight flags please? I'm new to MU and don't find a way how to create straight flags..

@cbjeukendrup
Copy link
Contributor Author

The problem is that there is no way to enable straight flags yet. I can implement that when PR #8867 is merged. (The screenshot at the top of this issue was taken from a development build that was made on top of that PR.)

For testing PR #9237, you could also look at the position of the grip box to make the stem longer or shorter; that one always appears at the end of the stem line.
Schermafbeelding 2021-09-23 om 16 36 54

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Sep 23, 2021

Make a 2nd PR on top of that one? Maybe as Draft, until the underlying one got merged?

@DmitryArefiev
Copy link
Contributor

The problem is that there is no way to enable straight flags yet. I can implement that when PR #8867 is merged. (The screenshot at the top of this issue was taken from a development build that was made on top of that PR.)

For testing PR #9237, you could also look at the position of the grip box to make the stem longer or shorter; that one always appears at the end of the stem line.
Schermafbeelding 2021-09-23 om 16 36 54

Thanks for the advice! That helped

@DmitryArefiev
Copy link
Contributor

Checked #8952 on Win10, Mac11.13.1, Linux Mint 20.2 - FIXED

[MU4.0 - ENGRAVING] automation moved this from Review in progress to Done Sep 24, 2021
RomanPudashkin added a commit that referenced this issue Sep 24, 2021
Fix #8952: Simplify/unify stem layout code and let it take SMuFL anchors of flag into account
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
4 participants