Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #8944 - Add right margin to system trailers #9158

Merged

Conversation

asattely
Copy link
Contributor

Resolves: #8944

image

Added a new style setting (not currently exposed in the UI) and documented it in https://github.com/musescore/MuseScore/wiki/Style-Parameter-changes-between-3.6-and-4.0

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Sep 17, 2021

IMHO 1.0 sp is quite a lot, maybe we'd better take the same default value as for clefLeftMargin, 0.8, timesigLeftMargin, 0.63 or keysigLeftMargin, 0.5 (seems timesigLeftMargin, 0.63 would be a nice compromise), which should make the courtesy clef, time- or key signature look nicely centered?
image
image

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 17, 2021
Backport of musescore#9158, different default, 0.67 rather than 1.0 though
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 17, 2021
Backport of musescore#9158, different default, 0.67 rather than 1.0 though
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 17, 2021
Backport of musescore#9158, different default, 0.67 rather than 1.0 though
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 17, 2021
Backport of musescore#9158, different default, 0.67 rather than 1.0 though
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 17, 2021
Backport of musescore#9158, different default, 0.67 rather than 1.0 though
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 20, 2021
Backport of musescore#9158, different default, 0.67 rather than 1.0 though
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 20, 2021
Backport of musescore#9158, different default, 0.67 rather than 1.0 though
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 21, 2021
Backport of musescore#9158, different default, 0.67 rather than 1.0 though
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 22, 2021
Backport of musescore#9158, different default, 0.67 rather than 1.0 though
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
Backport of musescore#9158, different default, 0.67 rather than 1.0 though
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 24, 2021
Backport of musescore#9158, different default, 0.67 rather than 1.0 though
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 26, 2021
Backport of musescore#9158, different default, 0.67 rather than 1.0 though
@asattely
Copy link
Contributor Author

going to reduce the default margin rq, don't merge quite yet!

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 27, 2021
Backport of musescore#9158, different default, 0.67 rather than 1.0 though
@asattely asattely force-pushed the padding-after-key-timesig-announce branch from 7e04f3e to 2b33235 Compare September 27, 2021 18:06
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 28, 2021
Backport of musescore#9158, different default, 0.67 rather than 1.0 though
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 28, 2021
Added new style parameter for trailer right margin

Backport of musescore#9158
@vpereverzev vpereverzev merged commit 83e8bfd into musescore:master Sep 28, 2021
@DmitryArefiev
Copy link
Contributor

Assigning to @vshalkevich

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 29, 2021
Added new style parameter for trailer right margin

Backport of musescore#9158
@DmitryArefiev
Copy link
Contributor

Checked #8944 on Win10, Mac11.13.1, Linux Mint 20.2 - FIXED

FYI @Tantacrul @oktophonie Comparison old and new distance:

bandicam.2021-09-29.16-36-51-409.mp4

@DmitryArefiev DmitryArefiev removed their assignment Sep 29, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Oct 3, 2021
Added new style parameter for trailer right margin

Backport of musescore#9158
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Dec 7, 2021
Added new style parameter for trailer right margin

Backport of musescore#9158
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
Added new style parameter for trailer right margin

Backport of musescore#9158
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
Added new style parameter for trailer right margin

Backport of musescore#9158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MU4 Issue] System-final time/key signature should have padding to right
6 participants