Fix #8952: Simplify/unify stem layout code and let it take SMuFL anchors of flag into account #9237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
changed the title
This was referenced Sep 23, 2021
|
Checked #8952 on Win10, Mac11.13.1, Linux Mint 20.2 - FIXED Please merge into master (@RomanPudashkin ) |
RomanPudashkin
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #8952
Also fixes an issue that has existed for a longer time, where on a TAB staff, the width of the stem of the start chord of a beam influences the end position of the beam:
It would be nice if the vtests could be repaired... that would give a lot more confidence. But I tested it with all cases I could think of (normal staves, different kinds of TAB staffs; with and without beams; tremolos...)