Fade-in articulation in GP4 and GP5 formats #988
Conversation
| @@ -1658,6 +1658,12 @@ void OveToMScore::convertArticulation( | |||
| cr->add(a); | |||
| break; | |||
| } | |||
| case OVE::Articulation_Fade :{ | |||
There was a problem hiding this comment.
If you know nothing about the ove format, I wouldn't change the code in importove.cpp, ove.cpp and ove.h
|
Thanks for the comments! I've updated the PR with another commit which takes your comments into account. |
| @@ -3531,4 +3531,4 @@ | |||
| "wiggleVIbratoLargestSlower", | |||
| "wiggleVibratoLargestSlowest" | |||
| ] | |||
| } | |||
There was a problem hiding this comment.
Would be great if you can let the bravura files untouched.
|
Yay! Finally some proper dynamics in playback! |
|
@euwbah not sure what you expect, but this PR has nothing to do about playback. It "just" imports the fadein symbols from guitar pro files. |
|
Oh okay.. i thought musescore would finally have dynamics on a single note XD |
|
Looks good now. Could you squash all these commits in one? |
|
Yeah sure, no problem. |
|
Does travis just need a kick on this? I can't see any actual tests failing either in that report or on my end. |
|
I ran travis again. |
|
Thanks! Gave me a diff that time, must have got lost in that previous run somehow. All should be well now. :-) |
Fade-in articulation in GP4 and GP5 formats
|
hello ,Can you give me .ove/.ovex file format document,I will development staff ,thank you !!! |
|
@liufeigit better request that via the musescore.org forum or the musescore developers' mailing list |
Adds support for importing the 'fade in' articulation for GP4 and GP5 formats. GP6 support has yet to be created. (Note that the fade out symbol is Guitar Pro 6 specific, I'll bundle that in with the fade in articulation support for GP6 in a future pull request.)