-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat dynamic buttons #254
Feat dynamic buttons #254
Conversation
I tried having a go documenting the types back in the Mk1 recipe. Back then, the names were:
I'd happily support anything which remained sensibly consistent. Sticking "Dynamic" at the front of an otherwise static widget-type seems reasonable to me. As for the suffix. It looks like /issues/252 is most similar to Button from Mk1. So, I would say, DynamicButton, not unlike Select -> DynamicSelect. edit* DynamicButtonGroup is even better. Here is a static ButtonGroup.
|
bring branch up to date
Late to the party here I know, sorry. The other option is to add a type attribute, e.g. |
Hey @morimoriysmoon, Yeah, I've been thinking that I'm not comfortable with the name
In this UI framework the select refers to the appearance of a selection box which is not relevant here. dynamic is the key concept we're adding here. This is all wishy-washy but Can you please update the code accordingly and let's finally put this to bed. |
Covers issue /issues/252.
@mcartmel - please review naming, etc.
@scroix - do you have any opinion on the naming given it's based on the
<dynamicselect>
element;<dynamicselectbuttons>
has been chosen for now.I was thinking maybe just
<dynamicbuttons>
or<dynamicbuttongroup>
?