Fix FTP test leaving behind temporary files #526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs in the FTP tests:
test_appe
was leaving behind temporary files inconpot/tests/data/data_temp_fs/ftp
test_help
contained an assert that AFAICT was always true (the one marked "test command specific help")Since I was already looking at the file I also refactored some test initialization code.
Caveat: I saw some occasional failures in the FTP tests which looked like race conditions to me, where one test would sometimes find a file another test had created. I don't think my particular changes are to blame but I can't be sure.