Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker fixes #282

Merged
merged 7 commits into from
Jan 18, 2019
Merged

Docker fixes #282

merged 7 commits into from
Jan 18, 2019

Conversation

leftshift
Copy link
Contributor

The docker files and docker-compose.yml had various little problems:

  • The config in docker/tanner/dist/config.py wasn't up-to-date, so tanner didn't actually start.
    Overriding the python config file is probably not the best way to do this anyways, but this fixes it for now
  • phpox didn't work due to a missing package and different binary names
  • various directories needed to be writable

Also, I backported phpox/#5. Again, this is required because sandbox.py is overwritten to change config values, which probably isn't the nicest way to do this

@coveralls
Copy link

Pull Request Test Coverage Report for Build 775

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.705%

Totals Coverage Status
Change from base Build 756: 0.0%
Covered Lines: 913
Relevant Lines: 1639

💛 - Coveralls

@glaslos glaslos requested a review from afeena November 28, 2018 08:49
@afeena afeena merged commit 1b6c5e5 into mushorg:master Jan 18, 2019
@afeena
Copy link
Collaborator

afeena commented Jan 18, 2019

Thanks for the contribution! (and sorry for long waiting)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants