Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Exec Tests #297

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Command Exec Tests #297

merged 2 commits into from
Mar 25, 2019

Conversation

rjt-gupta
Copy link
Collaborator

cmd-exec emulator coverage reached 100%.

@coveralls
Copy link

coveralls commented Mar 23, 2019

Pull Request Test Coverage Report for Build 835

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 55.793%

Totals Coverage Status
Change from base Build 822: 0.06%
Covered Lines: 915
Relevant Lines: 1640

💛 - Coveralls

@rjt-gupta rjt-gupta changed the title Command Execution Emulator Command Exec Tests Mar 24, 2019
@@ -13,6 +13,12 @@ def setUp(self):
self.sess = mock.Mock()
self.sess.sess_uuid.hex = 'e86d20b858224e239d3991c1a2650bc7'

def test_scan(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add please also case with negative result

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@rjt-gupta
Copy link
Collaborator Author

Added negative test.

@afeena afeena merged commit d5ef4ba into mushorg:master Mar 25, 2019
@rjt-gupta rjt-gupta deleted the cmd-exec-test branch March 25, 2019 13:48
afeena pushed a commit to afeena/tanner that referenced this pull request Jun 25, 2019
* cmd-exec

* negative test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants