Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with installing dependencies #358

Merged
merged 3 commits into from
Mar 4, 2020

Conversation

puneet29
Copy link
Contributor

The dependencies need to be installed in superuser mode else it results in errors.

@coveralls
Copy link

coveralls commented Feb 26, 2020

Pull Request Test Coverage Report for Build 1189

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.333%

Totals Coverage Status
Change from base Build 1188: 0.0%
Covered Lines: 1403
Relevant Lines: 1838

💛 - Coveralls

@mzfr
Copy link
Collaborator

mzfr commented Feb 27, 2020

In my opinion, rather than changing the installation command to run with sudo we should add a command to build the virtual env and then run the installation command inside the venv without any sudo

@Parth1811
Copy link
Contributor

@puneet29 I have already added a PR with a better version of README in #355, please have a look I have added your suggestion as well.
Also, I agree with @mzfr that there should be a virtual environment for TANNER, I would try to push a PR for that soon.

@puneet29
Copy link
Contributor Author

Yeah, I suggested for the virtual environment too @mzfr @Parth1811
Also, I will close this pr once yours is merged.

@afeena
Copy link
Collaborator

afeena commented Mar 3, 2020

@puneet29 I've merged #355, please update your changes accordingly, thanks!

@puneet29
Copy link
Contributor Author

puneet29 commented Mar 4, 2020

@afeena I've updated the pull request as requested.

@afeena afeena merged commit de1b5ed into mushorg:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants