-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display support for Slimproto players floods the client with unhandled grfe message #2118
Comments
https://music-assistant.io/installation/#server-notes please confirm you aren’t running LMS and the slimproto player at the same time on the same network please also add everything that you have tried or confirmed from the troubleshooting page in the docs that hasn’t helped. |
Ofc, only LMS OR MASS is running on the same time, HA has no slim* integration too. Additionally, the display support also disabled (with exactly same sdebug log sequence for the grfe): ralph-irving/squeezelite#219 Additionally the
|
Go into the player settings and make sure that display support is disabled. Also its safe to ignore these warning. Remember that MA is not a full drop in replacement for a full LMS server (with a 25 year history) - we just implemented what is enough to provide proper playback and didnt implement every quirk. |
I suggest you to first test it with a squeezelite client on your local pc or whatever. |
Neither disabling the display support (nor enabling with NONE or with the rest options) brings no change for me at none of the the latest-stable squeezelite based players. In the meantime I've found the guilty PR: #1131 with the b106 the log is not coming, with the b107 it is coming. .....and as of now, we should separate the |
I've added some debug log
|
Suffering from the same error spamming with the utterly simple setup of the squeezelite addon (supervised install), connected to the Local Aux output. |
unhandled vers is unavoidable - we are not LMS ! No big deal. Sure, nice to fix it but if someone has playback issues it will not have anything to do with that log |
marked as bug to be fixed (the display code should not be called, that is why you see that grfe message). For playback issues, please create a new issue as that is completely unrelated to having 'unhandled grfe' or vers messages in your squeezelite log (like I said above, that is just squeezelite saying it received a command it has no handler for) |
ok, it's acceptable. I've played a few hours yesterday but it was unsuccessful in my time-box based manner. You are right, it just a log entry as a response for the helo_process...
Great, thank's! I'm glad to be useful to uncover a misbehavior. For the playback issue, as of now, I see that it is irrelevant for the above mentioned logs, but as I see it is confirmed by others as well. |
Well, release 2.0 has come and gone ... :-( |
Is there anything you want to say here ? Remember that this is just a log - we have much more important things to handle. A workaround has been PR'ed and merged and it will be in the next update. |
Was just referring to what you said on Apr 15 'we'll fix this soon when time allows it but before the official 2.0 release'. |
The time did not allow it. The contribution is open for everyone. Everyone mean implicitly You as well.
I'm also very happy to do any contribution (bug find, report then resolve) on my own, in my free time, for You: the community. ;) I'm glad and really appreciate your appreciation. |
Now that the fix (to set display options OFF by default) I think its safe to close this bug report ? |
As far as I'm concerned: YES ! |
What version of Music Assistant has the issue?
2.0.0b135
What version of the Home Assistant Integration have you got installed?
2024.3.6
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?
The problem
I'm trying to swap my LMS docker server with a standalone mass-docker. I have a GioF71/squeezelite-docker player on another machine (same with large/hassio-addons). It is properly parameterized and properly working with LMS. After I try to swap to MASS-docker, my (slimproto) player gives the following error messages at startup:
after that every 5 sec I get:
[02:23:21.662324] process:532 unhandled grfe
tracking the timestamps, the player (DE:AD:BE:EF:F0:0D/Player) is connected and registered on MASS side, at startup but nothing further logs (neither in verbose log) which are in parallel with the client errors.
During start of the play (source does not matter), it gives more unhandled messages on the client side then MASS stops playing after a few secs without any (non-debug) log. On the player side nothing started.
On last year (b70-90) I had some success to play from mass, but for long time, it is impossible.
How to reproduce
start mass server, then start docker: GioF71/squeezelite-docker or large/hassio-addons in HA.
Music Providers
N/A (file-system, yt, tune-in, plex)
Player Providers
slimproto
Full log output
Additional information
No response
What version of Home Assistant Core are your running
2024.4.3
What type of installation are you running?
Home Assistant Supervised
On what type of hardware are you running?
Linux
The text was updated successfully, but these errors were encountered: