Slimproto: Turn off Display and visualization by default #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn off Display support and use None type visualization by default
|
I'm still getting: but only 1 time: at the startup of the client. - Maybe the display function is still called somewhere. (Just for the record: grfb is for the brightness, grfe is for rendering) |
marcelveldt
reviewed
May 24, 2024
marcelveldt
reviewed
May 24, 2024
|
Check the lint issues - otherwise good! |
Co-authored-by: Marcel van der Veldt <m.vanderveldt@outlook.com>
marcelveldt
changed the title
marcelveldt
pushed a commit
that referenced
this pull request
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn off Display support and use None type visualization by default. This PR tries to resolves the periodical "unhandled grfe" messages in the player's log as defined in music-assistant/hass-music-assistant/issues/2118