Subsonic: UNKNOWN_ARTIST handling #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelveldt
reviewed
Jul 7, 2024
music_assistant/server/providers/opensubsonic/sonic_provider.py
Outdated
Show resolved
Hide resolved
marcelveldt
reviewed
Jul 7, 2024
music_assistant/server/providers/opensubsonic/sonic_provider.py
Outdated
Show resolved
Hide resolved
We protect the get_artist_ablums() method this way, add the same check to get_artist_top_songs(). Signed-off-by: Eric B Munson <eric@munsonfam.org>
We want to be able to track down entries where the metadata is failing to parse at the provider level (or possible mismatches in representations between the provider and MA). Log the offending album or track when we have to use the UNKNOWN_ARTIST. Signed-off-by: Eric B Munson <eric@munsonfam.org>
khers
force-pushed
the
unknown-artists-logs
branch
from
dcdce98
to
a1c7165
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are playing a little fast and loose with this UKNOWN_ARTIST_ID, it should never escape from the provider code. The first patch here protects get_artist_toptracks() from sending this fake ID to the subsonic server. The second patch logs any time we find an album or track that ends up using UKNOWN_ARTIST.