Refactor image handling a bit #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll go ahead and merge this and adjust the frontend so you can give it a test and we address any issues you may find then. |
micha91
reviewed
Mar 27, 2023
Comment on lines
280
to
282
| encoded_url = urllib.parse.quote(urllib.parse.quote(img.url)) | ||
| return f"{self.mass.webserver.base_url}/imageproxy?path={encoded_url}" | ||
| return img.url |
There was a problem hiding this comment.
I think this should be img.path, right?
There was a problem hiding this comment.
oops, yes and thats why we invented code reviews :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the logic to resolve images that are not (or may be not) remotely accessible. Instead of limiting that functionality to the file providers, this is now useable for other providers too (e.g. Plex)