Develop barlines #1004
Merged
Develop barlines #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Component: Core Schema
rettinghaus
reviewed
Oct 2, 2022
* The `segno` barline means placing a segno sign on top of the barline, and the dblsegno means placing the very same sign on top of a double barline. The reference to E04B is only given as an indication on how it would look like and not for the glyph that has to be used. This is the same with the other barlines.
ahankinson
approved these changes
Oct 3, 2022
|
I'll wait for @musicEnfanthen to review and merge, since his review was requested, but it looks good to me. |
rettinghaus
approved these changes
Oct 3, 2022
musicEnfanthen
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add data types to bar lines
It also add the corresponding SMuFL codes whenever appropriate