Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop header footer #1008

Merged
merged 10 commits into from
Oct 14, 2022
Merged

Develop header footer #1008

merged 10 commits into from
Oct 14, 2022

Conversation

lpugin
Copy link
Member

@lpugin lpugin commented Oct 2, 2022

Following the discussion in #572, the PR removes pgHead2 and pgFoot2. They are replaced with a @func attribute on pgHead and pgFoot. The possible values are:

  • all
  • first
  • last
  • alt1
  • alt2

@github-actions github-actions bot added Component: Core Schema changes to source/modules/* (assigned automatically) Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) labels Oct 2, 2022
kepper
kepper reviewed Oct 2, 2022
View reviewed changes
source/modules/MEI.xml Outdated Show resolved Hide resolved
kepper
kepper previously approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the change

musicEnfanthen
musicEnfanthen reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@musicEnfanthen musicEnfanthen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Do we have any place in the Guidelines (text) where the old attributes are mentioned except the listing of attributes in 02-shared.xml?

Like here:

music-encoding/source/modules/MEI.shared.xml

Line 7550 in 304e9f2

<rng:ref name="pgHead2"/>
and

music-encoding/source/modules/MEI.shared.xml

Line 7556 in 304e9f2

<rng:ref name="pgFoot2"/>

musicEnfanthen
musicEnfanthen requested changes Oct 10, 2022
View reviewed changes
source/modules/MEI.shared.xml Outdated Show resolved Hide resolved
source/modules/MEI.xml Outdated Show resolved Hide resolved
source/modules/MEI.xml Outdated Show resolved Hide resolved
@lpugin @musicEnfanthen
Update source/modules/MEI.xml
d15bf79 
Fix typo the description

Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
pe-ro
pe-ro requested changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@pe-ro pe-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the unnecessary word "accordingly" from the description.

@bwbohl bwbohl self-assigned this Oct 13, 2022
pe-ro
pe-ro approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@pe-ro pe-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@musicEnfanthen
Copy link
Member

Thanks for the reviews.

@lpugin That one is still good to go also from your side?

@musicEnfanthen musicEnfanthen merged commit a195d1e into music-encoding:develop Oct 14, 2022
@musicEnfanthen musicEnfanthen mentioned this pull request Oct 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbohl bwbohl bwbohl left review comments

@pe-ro pe-ro pe-ro approved these changes

@musicEnfanthen musicEnfanthen musicEnfanthen approved these changes

@kepper kepper kepper left review comments

Assignees

@bwbohl bwbohl

Labels
Component: Core Schema changes to source/modules/* (assigned automatically) Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lpugin @musicEnfanthen @kepper @bwbohl @pe-ro