Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax schematron on beams #1012

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Relax schematron on beams #1012

merged 2 commits into from
Oct 20, 2022

Conversation

kepper
Copy link
Member

@kepper kepper commented Oct 2, 2022

No description provided.

@kepper
relax schematron on beams
cded3c6 
fixes #578. Relax schematron on beams with `@sameas` attribute, as done already with `@copyof`.
Co-authored by @riedde
Co-authored by @th-we
Co-authored by @pe-ro
@github-actions github-actions bot added the Component: Core Schema changes to source/modules/* (assigned automatically) label Oct 2, 2022
rettinghaus
rettinghaus approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@rettinghaus rettinghaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

lpugin
lpugin previously approved these changes Oct 3, 2022
View reviewed changes
musicEnfanthen
musicEnfanthen requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@musicEnfanthen musicEnfanthen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged after fixing AND to OR EDIT: See comments above

@musicEnfanthen musicEnfanthen changed the title relax schematron on beams Relax schematron on beams Oct 14, 2022
@musicEnfanthen
Copy link
Member

Fixes #578

rettinghaus
rettinghaus previously approved these changes Oct 19, 2022
View reviewed changes
@musicEnfanthen musicEnfanthen added this to 2022-10-27: ODD Thursday in ODD Meetings Oct 20, 2022
@musicEnfanthen musicEnfanthen modified the milestone: MEI 5.0.0 Oct 20, 2022
@bwbohl @rettinghaus @musicEnfanthen
Apply suggestions from code review
7a0e520 
With the more compact XPath expression `not(@copyof or @sameas)` and the Neither…nor in the description the intention now is much clearer.

Co-authored-by: Klaus Rettinghaus <klaus.rettinghaus@gmail.com>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
@bwbohl bwbohl dismissed stale reviews from rettinghaus and lpugin via 7a0e520 October 20, 2022 13:36
@bwbohl bwbohl merged commit 58a0eab into develop Oct 20, 2022
@bwbohl bwbohl deleted the develop-relax-beam-schematron branch October 20, 2022 13:39
@musicEnfanthen musicEnfanthen removed this from 2022-10-27: ODD Thursday in ODD Meetings Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahankinson ahankinson ahankinson left review comments

@pe-ro pe-ro pe-ro left review comments

@bwbohl bwbohl bwbohl approved these changes

@musicEnfanthen musicEnfanthen musicEnfanthen approved these changes

@lpugin lpugin lpugin left review comments

@rettinghaus rettinghaus rettinghaus left review comments

Assignees
No one assigned
Labels
Component: Core Schema changes to source/modules/* (assigned automatically)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kepper @musicEnfanthen @ahankinson @lpugin @bwbohl @pe-ro @rettinghaus