-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use official rng for svg from w3c #1013
Conversation
I'm very much +1 on this change. Have you verified this works? Because the TEI page is down I can't see the differences. Browsing around the TEI github it looks like they might have this one: The W3C one uses modules, while the TEI one seems to have things inline. Shouldn't be a problem but we should make sure it doesn't break anything. |
Unfortunately the build process doesn't resolve the linked modules correctly, resulting in non-functioning schemas. I'm not sure what the best solution is here. Should we just store the svg rng in our own repo? |
Is it possible to use the DTD? |
I took the rng from https://web.archive.org/web/20220320030131/https://tei-c.org/release/xml/tei/custom/schema/relaxng/svg11.rng locally, which wouldn't break things. But yes, we should have it locally… |
So this needs to be reworked, right? |
@kepper where should it go? Into |
I think we should just host it on music-encoding.org, and not in the core schema. Or are there technical reasons to host it in the schema? |
I would keep it locally in the core schema repo (preferably in source), so that you have everything in place to build the schemata from there, without external dependencies. Next time, it might be a Paderborn server that goes down and stops us from building, so having it in the same place seems safest. |
Isn't the MEI website hosted on GitHub? No Paderborn servers involved. :-D Although it might be worthwhile considering the case for building the schema offline? |
601e407
to
ebc773a
Compare
Added the RNG file to the source directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this, because I think it's the most reasonable and expedient fix.
However, some small part of me feels like we're losing something by not appealing to an external authority, but are instead making a local copy. Totally understand the reasons, but it's not really how it's supposed to work...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
completely agree with @ahankinson
@bwbohl I think you can probably merge this one. |
tei-c.org is down, so building the schema fails because of the hard-coded url for
svg11.rng
.In this PR it is replaced with the "official" rng from w3c.