Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official rng for svg from w3c #1013

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

rettinghaus
Copy link
Member

@rettinghaus rettinghaus commented Oct 3, 2022

tei-c.org is down, so building the schema fails because of the hard-coded url for svg11.rng.
In this PR it is replaced with the "official" rng from w3c.

@github-actions github-actions bot added the Component: Customizations changes to customizations/**/* (assigned automatically) label Oct 3, 2022
@ahankinson
Copy link
Member

I'm very much +1 on this change. Have you verified this works?

Because the TEI page is down I can't see the differences. Browsing around the TEI github it looks like they might have this one:

https://raw.githubusercontent.com/TEIC/Stylesheets/4ee458aedd5b6cb62d4882d1ae5ac2f0dfacbcb8/profiles/iso/schema/svg11.rng

The W3C one uses modules, while the TEI one seems to have things inline. Shouldn't be a problem but we should make sure it doesn't break anything.

@rettinghaus
Copy link
Member Author

Unfortunately the build process doesn't resolve the linked modules correctly, resulting in non-functioning schemas. I'm not sure what the best solution is here. Should we just store the svg rng in our own repo?

@ahankinson
Copy link
Member

Is it possible to use the DTD?

@kepper
Copy link
Member

kepper commented Oct 3, 2022

I took the rng from https://web.archive.org/web/20220320030131/https://tei-c.org/release/xml/tei/custom/schema/relaxng/svg11.rng locally, which wouldn't break things. But yes, we should have it locally…

@musicEnfanthen
Copy link
Member

So this needs to be reworked, right?

@rettinghaus
Copy link
Member Author

@kepper where should it go? Into customizations or source?

@ahankinson
Copy link
Member

I think we should just host it on music-encoding.org, and not in the core schema. Or are there technical reasons to host it in the schema?

@kepper
Copy link
Member

kepper commented Oct 3, 2022

I would keep it locally in the core schema repo (preferably in source), so that you have everything in place to build the schemata from there, without external dependencies. Next time, it might be a Paderborn server that goes down and stops us from building, so having it in the same place seems safest.

@ahankinson
Copy link
Member

Isn't the MEI website hosted on GitHub? No Paderborn servers involved. :-D

Although it might be worthwhile considering the case for building the schema offline?

@rettinghaus
Copy link
Member Author

Added the RNG file to the source directory.

Copy link
Member

@ahankinson ahankinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this, because I think it's the most reasonable and expedient fix.

However, some small part of me feels like we're losing something by not appealing to an external authority, but are instead making a local copy. Totally understand the reasons, but it's not really how it's supposed to work...

Copy link
Member

@bwbohl bwbohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completely agree with @ahankinson

@ahankinson
Copy link
Member

@bwbohl I think you can probably merge this one.

@bwbohl bwbohl merged commit b814e5d into music-encoding:develop Oct 7, 2022
@rettinghaus rettinghaus deleted the develop-svg branch October 21, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customizations changes to customizations/**/* (assigned automatically)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants