Develop metersig #1020
Merged
Develop metersig #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First step in implementing music-encoding#504 (comment) * At this stage, att.meterSig.log and att.meterSigDefault.log remain empty. The are still referenced in the schema
* Second step for the implementation of music-encoding#504 (comment) * A small difference with the proposal is the value, namely "sym+norm" rather than "norm+sym" because the common practice is to show the symbol before the numbers.
This reverts commit db77276.
* This step of the proposal music-encoding#504 (comment) * Instead of "unknown", the attribute value added is "other" because it seemed more appropriate
github-actions
bot
added
the
Component: Core Schema
|
Anything problematic with this PR? Pinging @kepper and @musicEnfanthen |
musicEnfanthen
requested changes
Oct 8, 2022
|
@lpugin No, just two small questions about clarification. Thanks for the reminder |
|
Also, would we need to adjust the desc of meterSigGrp element? https://music-encoding.org/guidelines/dev/elements/meterSigGrp.html – Used to capture alternating, interchanging, mixed or any other non-standard meter signatures. [??] |
Adjust description for sym+norm Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
pe-ro
requested changes
Oct 9, 2022
musicEnfanthen
approved these changes
Oct 10, 2022
|
@pe-ro May I ask you to re-review since Github dismisses a former review when new commits are added to a PR. Many thanks! |
pe-ro
approved these changes
Oct 10, 2022
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sym+norm to data.METERFORM
Add other as possible value in att.meterSigGrp.log@func
Closes #504