Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix model class members display in guidelines #1024

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix model class members display in guidelines #1024

merged 1 commit into from
Oct 11, 2022

Conversation

kepper
Copy link
Member

@kepper kepper commented Oct 3, 2022 •
edited

this fixes #988, plus some other display issues (duplicate elements in containedBy at https://music-encoding.org/guidelines/dev/elements/dot.html for instance)

@github-actions github-actions bot added the Component: Utils changes to utils/**/* (assigned automatically) label Oct 3, 2022
@kepper kepper changed the title fix model class class fix model class members Oct 3, 2022
@kepper kepper changed the title fix model class members fix model class members display in guidelines Oct 3, 2022
rettinghaus
rettinghaus approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@rettinghaus rettinghaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@musicEnfanthen
Copy link
Member

Pinging @bwbohl or @lpugin

lpugin
lpugin approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@lpugin lpugin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - not having looked at the details

@musicEnfanthen musicEnfanthen merged commit 41b1e50 into develop Oct 11, 2022
@musicEnfanthen musicEnfanthen deleted the fix-model-class-nesting-specs branch October 11, 2022 10:03
@musicEnfanthen
Copy link
Member

Thank you all

@musicEnfanthen musicEnfanthen changed the title fix model class members display in guidelines Fix model class members display in guidelines Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpugin lpugin lpugin approved these changes

@rettinghaus rettinghaus rettinghaus approved these changes

@musicEnfanthen musicEnfanthen musicEnfanthen approved these changes

@bwbohl bwbohl Awaiting requested review from bwbohl

Assignees
No one assigned
Labels
Component: Utils changes to utils/**/* (assigned automatically)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Submodels are not shown in the guidelines
4 participants
@kepper @musicEnfanthen @lpugin @rettinghaus