Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify remarks for elements based on other standards #1027

Merged
merged 26 commits into from
Oct 20, 2022
Merged

Clarify remarks for elements based on other standards #1027

merged 26 commits into from
Oct 20, 2022

Conversation

doerners
Copy link
Contributor

@doerners doerners commented Oct 4, 2022

This PR hopefully implements the task given in #878 and clarified in #1002 sufficiently.

Closes #878
Closes #1002

@doerners doerners requested review from kepper and pe-ro October 4, 2022 15:36
@github-actions github-actions bot added the Component: Core Schema changes to source/modules/* (assigned automatically) label Oct 4, 2022
kepper
kepper previously approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many, many thanks, @doerners – good job, especially with pulling out the links for multiple other standards 👍

pe-ro
pe-ro requested changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@pe-ro pe-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "respective" isn't necessary.

"The model of this element is based on the 
<ref target="https://tei-c.org/release/doc/tei-p5-doc/en/html/ref-teiCorpus.html">teiCorpus</ref> 
element of the Text Encoding Initiative (TEI).

is better.

@doerners doerners requested review from pe-ro and kepper October 10, 2022 16:09
@doerners
Copy link
Contributor Author

As per @pe-ro's request I deleted the term "respective" and am kindly asking both @kepper and @pe-ro to have another look :)

@musicEnfanthen musicEnfanthen mentioned this pull request Oct 10, 2022
Closed
pe-ro
pe-ro approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@pe-ro pe-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@musicEnfanthen
Copy link
Member

@kepper Your previous approval was discarded by GitHub after the latest changes by @doerners . May I ask you to re-review? Many thanks.

@musicEnfanthen
Copy link
Member

Closes music-encoding/guidelines#189

@bwbohl bwbohl assigned musicEnfanthen and unassigned rettinghaus Oct 18, 2022
@musicEnfanthen musicEnfanthen added this to the MEI 5.0.0 milestone Oct 20, 2022
@musicEnfanthen musicEnfanthen added this to 2022-10-27: ODD Thursday in ODD Meetings Oct 20, 2022
@musicEnfanthen musicEnfanthen removed this from the MEI 5.0.0 milestone Oct 20, 2022
@musicEnfanthen musicEnfanthen merged commit 5d0f57a into music-encoding:develop Oct 20, 2022
@musicEnfanthen
Copy link
Member

Thank you everyone!

@musicEnfanthen musicEnfanthen mentioned this pull request Oct 20, 2022
Closed
@musicEnfanthen musicEnfanthen removed this from 2022-10-27: ODD Thursday in ODD Meetings Oct 20, 2022
@doerners doerners deleted the develop-concordances branch October 20, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbohl bwbohl bwbohl approved these changes

@pe-ro pe-ro pe-ro approved these changes

@kepper kepper Awaiting requested review from kepper

Assignees

@bwbohl bwbohl

@musicEnfanthen musicEnfanthen

Labels
Component: Core Schema changes to source/modules/* (assigned automatically)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify remarks for elements that are modelled after other standards
6 participants
@doerners @musicEnfanthen @kepper @bwbohl @pe-ro @rettinghaus