Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(MEI.shared): Remove text.dist and add specific alternatives #1032

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

rettinghaus
Copy link
Member

This PR removes @text.dist from att.distances and add the more specific attributes @dir.dist, @tempo.dist, and @reh.dist.
Closes #439

@github-actions github-actions bot added the Component: Core Schema changes to source/modules/* (assigned automatically) label Oct 11, 2022
@bwbohl bwbohl requested review from lpugin and pe-ro October 11, 2022 13:33
@bwbohl bwbohl self-assigned this Oct 11, 2022
@bwbohl
Copy link
Member

bwbohl commented Oct 18, 2022

@pe-ro any chance of giving a review for this?

Copy link
Contributor

@pe-ro pe-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@musicEnfanthen musicEnfanthen merged commit 07b526a into music-encoding:develop Oct 20, 2022
@musicEnfanthen
Copy link
Member

Thank you!

@rettinghaus rettinghaus deleted the develop-textdist branch October 20, 2022 20:21
@musicEnfanthen musicEnfanthen changed the title Remove text.dist and add specific alternatives BREAKING(MEI.shared): Remove text.dist and add specific alternatives Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Schema changes to source/modules/* (assigned automatically)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clarify usage of text.dist
5 participants