Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link moduleFacet to module description #1038

Merged
merged 1 commit into from
Oct 19, 2022
Merged

link moduleFacet to module description #1038

merged 1 commit into from
Oct 19, 2022

Conversation

bwbohl
Copy link
Member

@bwbohl bwbohl commented Oct 18, 2022

This commit adds an HTML link to the module facet in the specs, e.g. in an element's description

@github-actions github-actions bot added the Component: Utils changes to utils/**/* (assigned automatically) label Oct 18, 2022
@bwbohl bwbohl added the Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) label Oct 18, 2022
@bwbohl bwbohl requested review from musicEnfanthen, rettinghaus and kepper and removed request for musicEnfanthen October 18, 2022 21:43
rettinghaus
rettinghaus approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@rettinghaus rettinghaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

kepper
kepper approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't checked the actual link to be functional, but generally it's a good thing 👍 thanks, @bwbohl

@bwbohl bwbohl merged commit d0fed7b into music-encoding:develop Oct 19, 2022
@bwbohl bwbohl deleted the ftr/linkModuleFacet branch May 2, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kepper kepper kepper approved these changes

@rettinghaus rettinghaus rettinghaus approved these changes

Assignees

@musicEnfanthen musicEnfanthen

Labels
Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) Component: Utils changes to utils/**/* (assigned automatically)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bwbohl @kepper @rettinghaus @musicEnfanthen