Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring facs description in line with TEI #1045

Merged
merged 3 commits into from
Nov 25, 2022
Merged

Bring facs description in line with TEI #1045

merged 3 commits into from
Nov 25, 2022

Conversation

rettinghaus
Copy link
Member

This PR brings the description of @facs in line with the TEI.
Also a link to the surface element has been added.

@github-actions github-actions bot added the Component: Core Schema changes to source/modules/* (assigned automatically) label Oct 30, 2022
pe-ro
pe-ro requested changes Oct 30, 2022
View reviewed changes
Copy link
Contributor

@pe-ro pe-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Descriptions typically begin with a capital letter, so "Points" instead of "points".

@rettinghaus rettinghaus mentioned this pull request Oct 30, 2022
Closed
pe-ro
pe-ro approved these changes Oct 30, 2022
View reviewed changes
Copy link
Contributor

@pe-ro pe-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@musicEnfanthen musicEnfanthen added this to 2022-11-25: ODD Friday in ODD Meetings Nov 25, 2022
@musicEnfanthen musicEnfanthen added the Status: Ready To Merge indicates that a pull request is ready for merging label Nov 25, 2022
@bwbohl bwbohl merged commit 8246fd1 into music-encoding:develop Nov 25, 2022
@musicEnfanthen musicEnfanthen removed the Status: Ready To Merge indicates that a pull request is ready for merging label Nov 25, 2022
@rettinghaus rettinghaus deleted the dev/facs branch November 25, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbohl bwbohl bwbohl approved these changes

@pe-ro pe-ro pe-ro approved these changes

Assignees
No one assigned
Labels
Component: Core Schema changes to source/modules/* (assigned automatically)
Projects
No open projects
ODD Meetings
  
2022-11-25: ODD Friday
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rettinghaus @bwbohl @pe-ro @musicEnfanthen