Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add glossaries to attribute definitions #1047

Merged
merged 5 commits into from
Jan 27, 2023
Merged

Add glossaries to attribute definitions #1047

merged 5 commits into from
Jan 27, 2023

Conversation

rettinghaus
Copy link
Member

This PR adds glossaries to some attributes that contain their full name.

@github-actions github-actions bot added the Component: Core Schema changes to source/modules/* (assigned automatically) label Oct 30, 2022
@rettinghaus rettinghaus mentioned this pull request Oct 30, 2022
Closed
pe-ro
pe-ro previously approved these changes Oct 30, 2022
View reviewed changes
Copy link
Contributor

@pe-ro pe-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These glosses are fine, but we may just be buying ourselves additional issues with rendering the documentation.

bwbohl
bwbohl previously approved these changes Oct 30, 2022
View reviewed changes
@rettinghaus rettinghaus dismissed stale reviews from bwbohl and pe-ro via 5d50fa6 November 11, 2022 08:43
@musicEnfanthen
Copy link
Member

@rettinghaus Could you fix the merge conflict?

@musicEnfanthen
Copy link
Member

@pe-ro @bwbohl May I ask you to re-review since your former approvals have been dismissed by the latest changes.

pe-ro
pe-ro approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@pe-ro pe-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bwbohl bwbohl merged commit 1a62535 into music-encoding:develop Jan 27, 2023
@rettinghaus rettinghaus deleted the dev/attr-gloss branch January 27, 2023 16:57
@bwbohl bwbohl added this to the MEI 5.0 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbohl bwbohl bwbohl approved these changes

@pe-ro pe-ro pe-ro approved these changes

Assignees
No one assigned
Labels
Component: Core Schema changes to source/modules/* (assigned automatically)
Projects
ODD meetings
Status: ✅ Done
Milestone
MEI 5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rettinghaus @musicEnfanthen @bwbohl @pe-ro