Unify usage and naming of attributes for controlling visibility of scoreDef properties #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Component: Core Schema
|
Since the PR now changes key signature attributes it would be good to adjust its title accordingly, or alternatively, to make a distinct PR. |
rettinghaus
changed the title
bwbohl
changed the title
lpugin
approved these changes
Apr 27, 2023
bwbohl
approved these changes
Apr 27, 2023
|
@bwbohl please check if guidelines need to be updated after this merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make
meterSigmember ofatt.visibilityand removes theinvisvalue fromdata.METERFORM, aligning this withclef. To keep the ability to hide the meter signature also when encoded as attributes onscoreDef/staffDefthis introducesmeter.visibleattribute.Moreover, it renames
keysig.showtokeysig.visibleto have a consistent naming of the attributes controlling the visibility.closes #1096