Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stress and unstress to data.ARTICULATION #1116

Merged
merged 1 commit into from
May 24, 2023
Merged

Add stress and unstress to data.ARTICULATION #1116

merged 1 commit into from
May 24, 2023

Conversation

rettinghaus
Copy link
Member

Closes #1114

@github-actions github-actions bot added the Component: Core Schema changes to source/modules/* (assigned automatically) label May 19, 2023
musicEnfanthen
musicEnfanthen approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@musicEnfanthen musicEnfanthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Though, we could think about sorting all available valitems in alphabetical order one day.

@ahankinson
Copy link
Member

Ready to merge.

@ahankinson ahankinson added the Status: Ready To Merge indicates that a pull request is ready for merging label May 23, 2023
@ahankinson ahankinson merged commit 702c61c into music-encoding:develop May 24, 2023
1 check passed
@ahankinson
Copy link
Member

Thanks!

@rettinghaus rettinghaus deleted the dev/artic branch May 24, 2023 19:08
@musicEnfanthen musicEnfanthen removed the Status: Ready To Merge indicates that a pull request is ready for merging label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahankinson ahankinson ahankinson approved these changes

@musicEnfanthen musicEnfanthen musicEnfanthen approved these changes

Assignees
No one assigned
Labels
Component: Core Schema changes to source/modules/* (assigned automatically)
Projects
ODD meetings
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stress and unstress values missing in data.ARTICULATION
3 participants
@rettinghaus @ahankinson @musicEnfanthen