-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new build workflow and add PDF Guidelines to build #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the list conforms to my memories as much as possible. I may be wrong on a couple of names, so changing them is certainly possible and necessary.
The files had a png extension, but were falsely encoded as bmp instead.
This will generate a file MEI_Guidelines_v5.0.0-dev_latest.html (at the time of writing) next to the mei-source.xml file. With PrinceXML installed, this file needs to be compiled with the command `prince MEI_Guidelines_v5.0.0-dev_latest.html`, which will result in a PDF of the same name and in the same folder. As of yet, this does not deal with embedding an DOI for non-development compilations.
Add: ORCID ID Gabriel Vigliensoni.
She is one of the lead contributors for the Mensural IG.
this is for our examples rendered live
update contributors
manually retrieve git hash only when running locally –> ant will set the $hash parameter properly
fix links
add whitespace
* remove paragraph on build system prerequisites
* update references xerces version closes #1111
remove deprecated comment
* rephrase
* fix spelling
Improve build instructions and reorganize README
github-actions
bot
added
Component: Build
changes to build.xml (assigned automatically)
Component: Core Schema
changes to source/modules/* (assigned automatically)
Component: Guidelines & Documentation
changes to source: docs, examples or web (assigned automatically)
Component: Images
changes to source/images/* (assigned automatically)
Component: Utils
changes to utils/**/* (assigned automatically)
Component: Workflows
changes to GitHub Actions workflows (assigned automatically)
labels
May 22, 2023
bwbohl
commented
May 22, 2023
ahankinson
previously approved these changes
May 22, 2023
ahankinson
reviewed
May 22, 2023
Co-authored-by: Andrew Hankinson <andrew.hankinson@rism.digital>
* use docker-mei for building schema and guidelines * copy build assets to schema
* fix typo in ant call
musicEnfanthen
changed the title
Add PDF Guidelines to build
Implement new build workflow and add PDF Guidelines to build
May 22, 2023
ahankinson
approved these changes
May 22, 2023
musicEnfanthen
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this PR.
PLEASE DO NOT MERGE. Merging will be done later this week during the DEV workshop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Build
changes to build.xml (assigned automatically)
Component: Core Schema
changes to source/modules/* (assigned automatically)
Component: Guidelines & Documentation
changes to source: docs, examples or web (assigned automatically)
Component: Images
changes to source/images/* (assigned automatically)
Component: Utils
changes to utils/**/* (assigned automatically)
Component: Workflows
changes to GitHub Actions workflows (assigned automatically)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.