Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): move schemata into correct folder and add canonicalized.xml #1134

Merged
merged 1 commit into from
May 24, 2023

Conversation

musicEnfanthen
Copy link
Member

@musicEnfanthen musicEnfanthen commented May 23, 2023

This PR fixes the step of the deploy action that copies the built schema into the expected folder in the schema repo. Previously, the schemata folder itself, created during the build, was copied to the dev folder. Now only the content of the schemata folder should be found in dev.

It additionally copies the missing mei-source_canonicalized.xml to the schema folder.

Fixes #1133
Fixes #1138

@github-actions github-actions bot added the Component: Workflows changes to GitHub Actions workflows (assigned automatically) label May 23, 2023
Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@bwbohl bwbohl merged commit 64e8492 into music-encoding:develop May 24, 2023
2 checks passed
@musicEnfanthen musicEnfanthen deleted the fix_deploy_action branch May 24, 2023 14:17
@bwbohl bwbohl added this to the MEI 5.0.0 milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Workflows changes to GitHub Actions workflows (assigned automatically)
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add canonicalized source to build assets build: schemata are deployed into wrong (nested) folder
3 participants