Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop basic cleanup #1141

Merged
merged 11 commits into from
May 25, 2023
Merged

Develop basic cleanup #1141

merged 11 commits into from
May 25, 2023

Conversation

lpugin
Copy link
Member

@lpugin lpugin commented May 24, 2023

This PR essentially removes elements that are not relevant for MEI basic but that were still through the inclusion of some modules.

The modules entirely removed are:

  • figtable
  • frbr
  • msDesc
  • text

For some modules, the definition of the elements available was changed from an @except list to a @include one to give a better understanding of what is available in MEI basic. This is the case for:

  • namesdates
  • meiHead
  • shared

The PR also adds instDef from midi.

It also put back @label and @type in att.common and allows pgHead and pgFoot in scoreDef (see #1128)

@github-actions github-actions bot added the Component: Customizations changes to customizations/**/* (assigned automatically) label May 24, 2023
@ahankinson
Copy link
Member

ahankinson commented May 24, 2023 •
edited

Looks good to me. I built the HTML page and the elements and attributes available look reasonable.

@bwbohl bwbohl added this to the MEI 5.0.0 milestone May 25, 2023
@lpugin lpugin marked this pull request as ready for review May 25, 2023 14:36
@pe-ro pe-ro merged commit 3d646ce into music-encoding:develop May 25, 2023
1 check passed
@lpugin lpugin deleted the develop-basic-cleanup branch May 25, 2023 17:32
@musicEnfanthen musicEnfanthen mentioned this pull request May 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahankinson ahankinson ahankinson approved these changes

@bwbohl bwbohl bwbohl approved these changes

@musicEnfanthen musicEnfanthen musicEnfanthen approved these changes

Assignees

@ahankinson ahankinson

@kepper kepper

@bwbohl bwbohl

Labels
Component: Customizations changes to customizations/**/* (assigned automatically) Component: MEI Basic
Projects
ODD meetings
Status: ✅ Done
Milestone
MEI 5.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lpugin @ahankinson @bwbohl @musicEnfanthen @kepper @pe-ro