Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow tstamp2.ges and tstamp2.real on metaMark #1151

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

kepper
Copy link
Member

@kepper kepper commented May 25, 2023

In #797 and #767 we were too fast in removing @tstamp2.ges and @tstamp2.real from <metaMark>, which was found when evaluating the diff of v4 and v5. Adding them back in, as agreed on the Charlottesville dev meeting.

In #797 and #767 we were too fast in removing `@tstamp2.ges` and `@tstamp2.real` from `<metaMark>`, which was found when evaluating the diff of v4 and v5. Adding them back in, as agreed on the Charlottesville dev meeting.
@kepper kepper added Status: Ready To Merge indicates that a pull request is ready for merging Type: Regression indicates that something went wrong and previous features have been lost unintentionally Type: Bugfix indicates that a fix for a bug has been provided labels May 25, 2023
@kepper kepper added this to the MEI 5.0.0 milestone May 25, 2023
@github-actions github-actions bot added the Component: Core Schema changes to source/modules/* (assigned automatically) label May 25, 2023
@musicEnfanthen musicEnfanthen added Status: Needs Review and removed Status: Ready To Merge indicates that a pull request is ready for merging labels May 25, 2023
Copy link
Contributor

@pe-ro pe-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pe-ro pe-ro merged commit c7feeb9 into develop May 25, 2023
1 check passed
@pe-ro pe-ro deleted the fix-metaMark-tstamp2 branch May 25, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Schema changes to source/modules/* (assigned automatically) Type: Bugfix indicates that a fix for a bug has been provided Type: Regression indicates that something went wrong and previous features have been lost unintentionally
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants