Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): include oxygen-basic-utilites in lib #1152

Merged
merged 1 commit into from
May 30, 2023

Conversation

musicEnfanthen
Copy link
Member

This PR adds the oxygen-basic-utilities for xerces in the lib folder when building with ant.

Fixes #1083

@github-actions github-actions bot added the Component: Build changes to build.xml (assigned automatically) label May 25, 2023
@musicEnfanthen
Copy link
Member Author

@bwbohl Do we need to enclose it in a condition that checks for Windows, or is it OK on all systems?

@musicEnfanthen musicEnfanthen added this to the MEI 5.0.0 milestone May 25, 2023
@bwbohl bwbohl self-assigned this May 26, 2023
@bwbohl
Copy link
Member

bwbohl commented May 30, 2023

It works on Windows now. @ahankinson did you text, too?
Finally fails on building the HTML Guidelines due to the login issue.

@ahankinson
Copy link
Member

No, I just checked it for consistency and syntax. I don't have a Windows machine to test it.

@bwbohl
Copy link
Member

bwbohl commented May 30, 2023

still works on my mac

@bwbohl bwbohl merged commit f93d889 into music-encoding:develop May 30, 2023
1 check passed
@musicEnfanthen musicEnfanthen deleted the fix-build-on-win branch May 30, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build changes to build.xml (assigned automatically)
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

build: native windows build fails
3 participants