Fixed: Use value of "schematron" for constraintSpec #1161
Merged
+179
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TEI has changed the value of "schematron" in its RNG. If we're thinking about moving towards pure ODD this change will mean one less thing that breaks. Also fixed an issue where the customizations were using the TEI RNG, but the sources were pointing to the (older) MEI RNG. These were normalized to the MEI RNG so that all source and customizations use the same ODD schema. Fixes #1158
github-actions
bot
added
Component: Core Schema
musicEnfanthen
approved these changes
May 26, 2023
|
FYI: I've also built it with the ant build script and it seems to work OK |
kepper
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TEI has changed the value of "schematron" in its RNG, but the MEI RNG allows both "isoschematron" and "schematron".
If we're thinking about moving towards pure ODD this change will mean one less thing that breaks when we update.
Also fixed an issue where the customizations were using the TEI RNG, but the sources were pointing to the (older) MEI RNG. These were normalized to the MEI RNG so that all source and customizations use the same ODD schema.
Fixes #1158