Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Key signature changes #1170

Merged
merged 11 commits into from
Jun 5, 2023
Merged

Fixed: Key signature changes #1170

merged 11 commits into from
Jun 5, 2023

Conversation

ahankinson
Copy link
Member

This PR contains changes to the key signature attributes on <keySig> and <staffDef> / <scoreDef>. It clarifies how key signature changes should be drawn, and makes the naming of the attributes more consistent.

Fixes #525

@ahankinson
Update examples with key signature changes
a053f80
@ahankinson
Fixed: Modify key signature attributes
7c417ca 
This PR addresses the changes requested in #525. It clarifies the drawing of cancellation accidentals when a new key signature is created,
and makes attribute names more consistent.

Fixes #525
@github-actions github-actions bot added Component: Core Schema changes to source/modules/* (assigned automatically) Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) labels May 27, 2023
@ahankinson
Copy link
Member Author

This is marked draft until I can write a paragraph or two in the guidelines about key signature changes.

rettinghaus
rettinghaus requested changes May 28, 2023
View reviewed changes
Copy link
Member

@rettinghaus rettinghaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, mostly looking fine.

source/modules/MEI.visual.xml Show resolved Hide resolved
source/modules/MEI.xml Show resolved Hide resolved
source/modules/MEI.xml Show resolved Hide resolved
ahankinson
ahankinson commented May 29, 2023
View reviewed changes
source/modules/MEI.xml Outdated Show resolved Hide resolved
@ahankinson ahankinson requested a review from a team May 30, 2023 04:26
@ahankinson ahankinson added this to the MEI 5.0 milestone May 30, 2023
@ahankinson ahankinson marked this pull request as ready for review May 30, 2023 04:26
lpugin
lpugin reviewed May 30, 2023
View reviewed changes
source/modules/MEI.xml Outdated Show resolved Hide resolved
@ahankinson @lpugin
Update source/modules/MEI.xml
50f5a8c 
Co-authored-by: Laurent Pugin <lxpugin@gmail.com>
rettinghaus
rettinghaus requested changes May 30, 2023
View reviewed changes
source/docs/04-cmn.xml Outdated Show resolved Hide resolved
source/modules/MEI.xml Show resolved Hide resolved
lpugin and others added 2 commits June 2, 2023 08:33
@lpugin @rettinghaus
Update source/docs/04-cmn.xml
34a1d9e 
Co-authored-by: Klaus Rettinghaus <klaus.rettinghaus@gmail.com>
@lpugin @musicEnfanthen
Update source/docs/04-cmn.xml
77fb919 
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
@bwbohl bwbohl merged commit 308bc2b into develop Jun 5, 2023
1 check passed
@bwbohl bwbohl deleted the fixed-525-keysig branch June 5, 2023 11:34
This was referenced Jun 13, 2023
Closed
Open
Closed
@musicEnfanthen musicEnfanthen mentioned this pull request Jun 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpugin lpugin lpugin approved these changes

@bwbohl bwbohl bwbohl approved these changes

@rettinghaus rettinghaus Awaiting requested review from rettinghaus

@musicEnfanthen musicEnfanthen Awaiting requested review from musicEnfanthen

Assignees
No one assigned
Labels
Component: Core Schema changes to source/modules/* (assigned automatically) Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) Priority: High
Projects
ODD meetings
Status: ✅ Done
Milestone
MEI 5.0
Development

Successfully merging this pull request may close these issues.

Harmonize key.sig et al. attributes on scoreDef, staffDef, key and keySig
5 participants
@ahankinson @lpugin @bwbohl @rettinghaus @musicEnfanthen