Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): remove xml declaration from example mei files #1178

Merged

Conversation

musicEnfanthen
Copy link
Member

This PR removes the XML declarations from the example mei files (to be rendered with Verovio) that were introduced in #1148 and seem to cause some Java parsing errors. In consequence, the code snippets from the files weren't rendered correctly.

Fixes #1175
Fixes #1177

@github-actions github-actions bot added the Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) label May 27, 2023
@musicEnfanthen musicEnfanthen added this to the MEI 5.0 milestone May 28, 2023
@ahankinson ahankinson merged commit 865afbd into music-encoding:develop May 29, 2023
1 check passed
@musicEnfanthen musicEnfanthen deleted the fix-java-parsing-errors branch May 30, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically)
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Code rendering is broken in the Guidelines XML snippets throw java errors
3 participants