Initial script for generating images using a python script instead of… #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Build
ahankinson
reviewed
May 30, 2023
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
ahankinson
reviewed
May 30, 2023
ahankinson
reviewed
May 30, 2023
ahankinson
reviewed
May 30, 2023
ahankinson
requested changes
May 30, 2023
ahankinson
reviewed
May 30, 2023
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
* Since having local options is currently not used we can remove the lxml dependency for now * The script will also fail if and example cannot be loaded or if the resulting SVG is empty
|
@lpugin looks like there's a merge conflict now. Could you please resolve this? |
…verovio-script # Conflicts: # BUILD_COMMANDLINE.md
There was a problem hiding this comment.
Thanks @lpugin. Tested locally and works great. Some minor suggestions below.
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
ahankinson
reviewed
May 31, 2023
ahankinson
requested changes
May 31, 2023
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
Co-authored-by: Andrew Hankinson <andrew.hankinson@gmail.com>
rettinghaus
reviewed
May 31, 2023
|
@musicEnfanthen is this also tested in the docker-mei container? |
|
@bwbohl I was able to execute the target from within docker-mei, yes. |
|
@ahankinson Are your requested changes addressed? |
musicEnfanthen
approved these changes
Jun 14, 2023
ahankinson
approved these changes
Jun 15, 2023
|
Many thanks for this I think it's much better to have a script for generating the images inside this repo and should even replace the other ant target and node.js method. |
bwbohl
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Python script offering an alternative to the node script for generating images with Verovio outside Docker.
The Python scripts dependencies are standard ones plus:
Both can be installed with
pipThe script can be run through a new
anta new targetgenerate-images-py(guidelines should have been built beforehand):