Adjust MEI- Basic customization to use att.duration.log for rest #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Component: Customizations
Co-authored-by: Klaus Rettinghaus <klaus.rettinghaus@enote.com>
bwbohl
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts
att.rest.login MEI-Basic to useatt.duration.loginstead ofatt.restduration.log.The reason for this change is that
att.restduration.logis meaningless in MEI-Basic since it exists essentially to allow for additional rest durations in mensural notation which are not available in MEI-Basic.The change in the customization yields no modification to the resulting MEI-Basic schema and is only intended to simplify handling of rests with code generated directly from the MEI-Basic ODD.