Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ending to MEI-Basic #1208

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

lpugin
Copy link
Member

@lpugin lpugin commented Jun 13, 2023

The PR adds <ending> element to MEI-Basic. It is currently missing, probably because it has been overlooked at some point.

I did not think this change needed preliminary discussions since it is a quite common feature in CWMN. Please say so if you think it does need to be discussed.

@github-actions github-actions bot added the Component: Customizations changes to customizations/**/* (assigned automatically) label Jun 13, 2023
Copy link
Member

@kepper kepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure! good catch 👍

@bwbohl bwbohl merged commit 1255289 into music-encoding:develop Jun 13, 2023
1 check passed
@bwbohl bwbohl added this to the MEI 5.0 milestone Jun 13, 2023
@lpugin lpugin deleted the develop-basic-ending branch June 13, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customizations changes to customizations/**/* (assigned automatically) Component: MEI Basic
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants