schema: fix visibility of mRest and multiRest #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Component: Core Schema
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
|
Out of curiosity, what's the point of an invisible multiRest? It would not cover any more measure space than an mSpace, right? |
|
Not really. Some publishers don't bother to show the exact length of a |
musicEnfanthen
changed the title
bwbohl
approved these changes
Jun 20, 2023
musicEnfanthen
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Thanks @rettinghaus. We should make sure that this change is reflected in the XSLT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restis not a member ofatt.visibility, because we havespace. So thatmRestactually is a member ofatt.visibilityseems wrong, because we havemSpace.multiReston the other hand was indeed missing thevisibleattribute.