Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guidelines: remove reference to ineume and uneume in chapter 6 #1230

Merged

Conversation

vigliensoni
Copy link
Contributor

This pull request removes the references to interrupted and uninterrupted neumes (ineume and uneume) from the guidelines.

Those are legacy references to interrupted and uninterrumpted neumes.
@github-actions github-actions bot added the Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) label Jun 16, 2023
@musicEnfanthen musicEnfanthen changed the title Fix: Remove reference to ineume and uneume. guidelines: remove reference to ineume and uneume in chapter 6 Jun 16, 2023
@musicEnfanthen
Copy link
Member

Thank you for this PR and fix, @vigliensoni. Just a minor question above.

@musicEnfanthen musicEnfanthen added this to the MEI 5.0 milestone Jun 16, 2023
Copy link
Contributor

@fujinaga fujinaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@ahankinson ahankinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve to move it forward, but this section needs work.

@musicEnfanthen
Copy link
Member

Agreed. Thank you @ahankinson for approval and @vigliensoni and @fujinaga for the PR.

@musicEnfanthen musicEnfanthen merged commit 19c4653 into music-encoding:develop Jul 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically)
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants