Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guidelines: bring back at-sign for attributes in PDF guidelines #1231

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

musicEnfanthen
Copy link
Member

This PR adds a CSS rule to print css to bring back the missing @ sign in front of the attributes mentioned in the text of the PDF guidelines.

Fixes #1227

@musicEnfanthen
Copy link
Member Author

Looks now like this:

Screenshot 2023-06-17 005422

@musicEnfanthen musicEnfanthen changed the title fix(guidelines): bring back at-sign for attributes in PDF guidelines guidelines: bring back at-sign for attributes in PDF guidelines Jun 16, 2023
@musicEnfanthen musicEnfanthen added this to the MEI 5.0 milestone Jun 16, 2023
Copy link
Member

@rettinghaus rettinghaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@bwbohl bwbohl added Component: Style Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) labels Jun 17, 2023
@bwbohl bwbohl merged commit 9d898d3 into music-encoding:develop Jun 20, 2023
2 checks passed
@musicEnfanthen musicEnfanthen deleted the fix-pdf branch June 20, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) Component: Style
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Ampersands indicating attributes missing in PDF
4 participants